Skip to content

Per-class probablibity being treated as per-sample probability. #10

Description

@souravraha

M2m/train.py

Line 167 in 42d08a5

select_idx = torch.multinomial(p_accept, 1, replacement=True).view(-1)

@jh-jeong
In the line above p_accept is supposed to be "per-class" probability distribution. This is according to the definition of torch.multinomial. However, the implementation is treating it as a per-sample probability distribution. This is not how the subsection "Practical implementation via re-sampling" of https://arxiv.org/pdf/2004.00431.pdf describes this to be implemented. Could you shed some light on this? Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions