Complete factorization - #143
Merged
Merged
Conversation
odraccir1
force-pushed
the
ra/poly_factorization_12
branch
from
August 24, 2026 22:34
1c789bd to
9ab6110
Compare
spaceships
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting together the full polynomial factorization:
Factor a polynomial into monic irreducible factors by composing the three finite-field factorization stages:
1. Square-free factorization separates factors by their multiplicity in the input.
2. Kaltofen-Shoup distinct-degree factorization separates each square-free part into groups whose irreducible factors all have the same degree.
3. Cantor-Zassenhaus equal-degree factorization splits each group into individual irreducible factors.
This PR deals with polynomial factorization correctness and not performance. We are going to come back to performance and FLINT comparisons at a later time.
Depends on #142
Completes to #114