Sync manifest generator: key release-plumbing on paths, not layout - #33
Merged
Conversation
Adopts the fix from aws-observability/cortex-dev#286. The old is_release_plumbing keyed "product source" on Cortex's pkg/cmd/tools layout; this fork is flat, so a real carried change that also bumped go.mod was misread as release plumbing and silently dropped from the manifest. Plumbing is now an allow-list of dependency/CI paths, so an unrecognised path always counts as source and is kept. AWS-Change: fix AWS-Component: alertmanager Upstream-Status: none
danielblando
force-pushed
the
sync-manifest-generator-fix
branch
from
September 3, 2026 18:00
71bdad1 to
3695c38
Compare
Wassup789
approved these changes
Sep 3, 2026
alexqyle
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts aws-observability/cortex-dev#286. This fork (alertmanager) is flat-layout, so the old generator could silently drop a carried change that also bumped go.mod. The fix makes release-plumbing an allow-list of dependency/CI paths; an unrecognised path always counts as source and is kept. Byte-identical to the generator already running on thanos-promql-engine.