Bump the tapp submodule to the Windows-checkoutable revision - #13
Merged
Conversation
3335306fc -> d9290d07d, which includes amds-ldeo/tapp#2. The recorded revision could not be checked out on Windows at all: error: invalid path 'Archive/.migration_backup_group1_20260808/LA-Q:SF-ICPMS_TAPP_v5.csv' fatal: Unable to checkout '3335306fc' in submodule path 'tapp' A colon is illegal in a Windows filename, so `git submodule update` failed and any Windows working copy silently stayed on an older revision, showing a permanent ` M tapp` that was not a real change. Linux CI checked out fine, which is why it went unnoticed. Upstream renamed the archived file to LA-Q-SF-ICPMS_TAPP_v5.csv, reusing the same blob so the content and its history are untouched. Verified after the bump: the submodule checks out on Windows with no colon-bearing paths on disk, and all 16 techniques in TAPP_CONFIGS still resolve their source tables. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
tappsubmodule3335306fc→d9290d07d, picking up amds-ldeo/tapp#2.Why
The revision recorded on
maincould not be checked out on Windows at all:A colon is illegal in a Windows filename.
git submodule updatetherefore failed, any Windowsworking copy silently stayed on an older revision, and
git statusshowed a permanentM tappthat was not a real change — easy to mistake for local edits, and easy to stage by accident.
Linux CI checks out fine, which is why this went unnoticed.
Upstream renamed the archived file to
LA-Q-SF-ICPMS_TAPP_v5.csv, reusing the same blob, so itscontent and history are untouched.
Verified after the bump
TAPP_CONFIGSstill resolve their source tablesM tappis goneNote the newer revision also removes superseded tables (32 files, 2110 deletions, no insertions).
Every technique already migrated to a current table in #10 and #11, so nothing wired depends on the
removed ones.
🤖 Generated with Claude Code