feat(wallpapers): rework gallery and transition engine - #1083
Merged
Conversation
Split the wallpapers service into engine/gallery/images/manager and replace the old paged gallery with four layout types (default, magnified, strip, slide) selected through gallery.type. The transition engine now lays wallpapers out the way Windows does, so the last frame of the animation lands on the same pixels Windows settles on instead of jumping when the overlay closes: Add gallery.accent_color, deprecate the removed gallery options, and document the engine's dependency on Windows animation effects together with the known flash on very large images. - lay out the transcoded copy Windows uses, not the file on disk - anchor fill and span at a third of the vertical overflow, not a half - span wide landscape images across all monitors in fit and fill (autospan) - truncate integer division toward zero the way Windows does
- Track queued image loaders so they can be reordered or cancelled when the selection moves. - Queue and decode the cards nearest the selection first. - Drop queued loads that are no longer visible to save CPU and bandwidth. - Cap the image decoding pool at two threads to avoid starving the UI. - Repaint only when a decoded card is actually on screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the wallpapers service into engine/gallery/images/manager and replace the old paged gallery with four layout types (default, magnified, strip, slide) selected through gallery.type.
The transition engine now lays wallpapers out the way Windows does, so the last frame of the animation lands on the same pixels Windows settles on instead of jumping when the overlay closes:
Add gallery.accent_color, deprecate the removed gallery options, and document the engine's dependency on Windows animation effects together with the known flash on very large images.