fix: restore ability to build as a standalone static lib - #515
Open
crleona wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restores standalone static library build capability for the SDK to maintain compatibility with Unreal while also improving dependency management and addressing naming conflicts for server zones.
- Added a new build script for static library compilation across multiple platforms
- Updated server zone definitions to support prefixed constants in select environments
- Introduced conditional inclusion of the Analytics Connector and minor property attribute adjustments
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/build_static_libs.sh | Added a multi-platform build script for static library targets |
| Sources/Amplitude/Public/AMPServerZone.h | Applied a compiler flag to switch between prefixed and unprefixed enums |
| Sources/Amplitude/Public/AMPMiddleware.h | Updated property attributes and initializer declarations |
| Sources/Amplitude/Amplitude.m | Integrated conditional inclusion of Analytics Connector functionality |
| Sources/Amplitude/AMPServerZoneUtil.m | Updated switch cases to use new prefixed server zone constants |
| Podfile | Added use_frameworks and defined dependencies for Analytics Connector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our Unreal SDK was previously linked against a statically built version of v8.1.0 of this SDK, and we've since added several updates. The following changes are required to maintain compatibility with Unreal:
USandEUglobal constantsChecklist