fix: prevent background task id leak - #529
Open
winshaurya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sojingle
Description
This PR fixes a bug in
Amplitude.mthat can lead to leakedUIBackgroundTaskIdentifiers and subsequent watchdog termination crashes (0x8badf00d), particularly when Amplitude is used inside App Extensions.Changes Made:
endBackgroundTaskIfNeeded, if[AMPUtils getSharedApplication]returnsnil(which happens in extensions), the method was previously exiting early without resetting_uploadTaskID._uploadTaskID = UIBackgroundTaskInvalidis always executed, clearing the dangling state even ifUIApplicationis unavailable to formally end the task.PS: 1st pr in the Amplitude Org
Checklist