fix: prevent coretelephony initialization on simulators - #531
Open
winshaurya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@sojingle
Description
This PR fixes Issue #514 where instantiating
CTTelephonyNetworkInfoon iOS 14+ Simulators causes repetitive XPC lookup errors in the Xcode console (failed at lookup with error 3 - No such process).Since iOS simulators do not have cellular modems or carrier daemons, the
CTTelephonyNetworkInfoinitialization is entirely unnecessary on this target.Changes Made:
#if TARGET_OS_SIMULATORguard inside[AMPDeviceInfo carrier]to short-circuit carrier fetching on simulators.testCarrierunit test inDeviceInfoTests.mto verify the fallback behavior on simulator environments."Unknown"immediately, keeping the console log clean without altering production device behavior.Checklist