perf: refactor sqlite database connection lifecycle - #532
Open
winshaurya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
This PR addresses severe disk I/O thrashing and potential file descriptor leaks in
AMPDatabaseHelper.m.@sojingle
Previously,
sqlite3_open_v2andsqlite3_closewere being called on every single event insertion/query executed withininDatabase:. In high-volume event tracking scenarios, this constant opening and closing of the SQLite database file causes noticeable CPU/disk overhead and battery drain. Additionally,sqlite3_close()was failing silently when unfinalized statements were present.Changes Made:
AMPDatabaseHelperto maintain a single, persistentsqlite3 *_databasehandle scoped to the serial queue lifecycle.sqlite3_close(_database)indeallocanddeleteDB.This change yields a significant performance optimization for high-throughput tracking.
Checklist