ci: fix yaml syntax error in sdk_android_build.yml - #27
Closed
olehkuznetsov wants to merge 2 commits into
Closed
Conversation
… replay When replaying a capture with --remove-unsupported, GFXReconstruct removes unsupported extensions from VkDeviceCreateInfo but previously only disabled the corresponding features (setting them to VK_FALSE) in the feature structures within the pNext chain. This left the feature structures (like VkPhysicalDeviceFragmentDensityMapFeaturesEXT) in the pNext chain. Some drivers or layers (like RenderDoc) fail device creation if they encounter a feature structure for an extension that is not enabled, even if all features in that structure are set to VK_FALSE. This change modifies the generator to produce a `FilterPNextFeatures` function that unlinks these unsupported feature structures from the pNext chain. This function is called during device creation setup. Also added Catch2 unit tests to verify the structure removal logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating from actions/create-release@v1 to the gh CLI tools, the previous yaml syntax map bindings for 'draft: false' and 'prerelease: false' were left dangling at the bottom of a 'run: |' block string which produced YAML parsing errors causing the workflow file to immediately crash upon triggering.