agents: give this whole tool a quick look and - #1
Merged
Conversation
Add rel="noopener noreferrer" and referrerpolicy="no-referrer" to release link to avoid leaking the session token in Referer headers when users open the release page.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Referrer headers, update client and CLI Publish token-less localhost URL so session tokens aren't leaked via the address bar or Referer; add GET /api/token for the same-origin page to fetch the token; add CSP, X-Frame-Options, Referrer-Policy and X-Content-Type-Options headers on responses; update web client to fetch token and adjust CLI messaging.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adjust the test to set the session token via the test's fake keychain (dashtouch_helper.keychain.set_session_token) so the test mirrors the Keychain-first behavior introduced in webui.py. Fall back to writing the token file if the fake keychain isn't available — keeps tests hermetic across CI environments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace file-backed fake keychain with direct mocks of dashtouch_helper.keychain in conftest. Add a lightweight integration test that exercises GET /api/token and a token-protected POST /api/enroll.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add pytest.ini with 'integration' marker and mark the HTTP integration test with @pytest.mark.integration so CI can run unit and integration suites separately.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Unit job runs pytest -m 'not integration' on PRs; integration job runs pytest -m integration on main pushes or manual dispatch.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add CONTRIBUTING.md with local test instructions and add actions/cache steps for pip in CI to speed up installs.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
List test/runtime deps used by CI (pytest, pyserial, cryptography) to stabilize cache key and make dependency updates explicit.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Print Python and workspace info for easier debugging and use requirements.txt for pip installs so cache key is stable.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
CI: pushed updates to .github/workflows/ci.yml to install from requirements.txt, added pip cache and diagnostics, and fixed tests + integration test placement. Pushing branch to trigger CI. If the unit job still fails, please paste the 'Show environment' step output here and I'll investigate further. |
…e in CI Run pytest as PYTHONPATH=. pytest ... inside helper to ensure dashtouch_helper is on sys.path in Actions runners.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
CI fix: set PYTHONPATH when running pytest in Actions so the helper package (dashtouch_helper) is importable. Pushed change to the branch to re-run CI. |
Wrap dashtouch_helper.keychain._run to convert FileNotFoundError into KeychainError on non-macOS runners while letting tests patch subprocess.run. This keeps keychain unit tests functional and prevents CI failure when the 'security' binary is absent.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
CI fix: wrap dashtouch_helper.keychain._run in tests to convert FileNotFoundError (missing macOS 'security' binary) into KeychainError so CI on Linux runners won't fail. Pushed change to branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created from
agents/give-this-whole-tool-a-quick-look-andtargetingmain.