feat(reminders): threshold filters

[ericli3690]

Purpose / Description

Add a group of new advanced review reminder options: count new cards, count cards in learning, and count cards in review. When the review reminder is about to send a notification and checks to see if the amount of cards in the deck is greater than the card trigger threshold, it examines these options to check if it should count and consider new cards, cards in learning, and cards in review.

Adds three new checkboxes to the AddEditReminderDialog to toggle these booleans on or off. Edits some logic in NotificationService to add up cards only from selected card type when determining whether the card trigger threshold is met.

Adds three new boolean fields to store the states of these settings to ReviewReminder. Adds unit tests.

UI

Fixes

• Review reminders: threshold filters #21749

Approach

One of the two planned review reminder advanced options! Just needs some extra checks when handling the Count objects.

How Has This Been Tested?

• Unit tests pass.
• Builds and runs on a physical Samsung S23, API 34.
• Based on my own personal testing, it seems the feature works! I created a few review reminders, reviewed a few cards, etc.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[ericli3690]

• Rebased.

[ericli3690]

• Rebased.

[ericli3690]

• Rebased.

[ericli3690]

Forgot to stage some code. Fixed.

[ericli3690]

Rebased, fully unblocked, and ready for review!

[ericli3690]

I've decided to keep the existing text ("Include [type] cards for card threshold") for now and will create an issue later to address possibly changing it to be more precise. I think that we should probably err on the side of verbosity to ensure users and translators understand what the string is supposed to mean. I've implemented making the text lowercase, too.

Due to #20163, we're putting this PR on hold until migrations on the main branch are stable. I'll also change this code to have the proper migration.

[ericli3690]

Hi @bhavESH-CHAWLA ! Thanks for the offer, but I've got it under control -- I'm currently writing a new PR to improve the backend database file and then I'm planning to rebase this one on top of it.

Sorry but good luck! I know it can sometimes be hard to find an open issue to work on in this project haha

[github-actions]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[ericli3690]

Working on a major refactor of the database! Then this guy will be rebased on top

[ericli3690]

Blocked behind:

• feat(reminders): database overhaul #20325

[ericli3690]

Dependency merged; will revise soon, please give me a few days.

[github-actions]

Important

Maintainers: This PR contains Strings changes

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review