feat: Deckpicker progress adoption - #21831
Open
criticalAY wants to merge 2 commits into
Open
criticalAY wants to merge 2 commits into
criticalAY wants to merge 2 commits into
Conversation
Every observer dismissed the one shared dialog on `Idle`, so with two observers in an activity, one could close the other's dialog. Assisted-by: Claude Opus 5 (implementation iteration and tests)
criticalAY
force-pushed
the
deckpicker-progress-adoption
branch
from
September 29, 2026 06:59
abd8194 to
b77fd6c
Compare
david-allison
added
the
Needs Author Reply
david-allison
requested changes
Sep 29, 2026
david-allison
left a comment
david-allison
left a comment
Member
There was a problem hiding this comment.
For the DeckPicker: we need to be sure that withProgress blocks operations immediately - modifying the selected deck can cause an operation to occur on the wrong decks.
This PR waits 600ms before performing blocking input, rather than blocking input immediately
Rest LGTM!
david-allison
added
Needs Author Reply
Comment on lines
300
to
302
| launchCatchingTask { | ||
| withProgress(TR.emptyCardsDeleting()) { | ||
| viewModel.deleteEmptyCards(report, keepNotes).join() | ||
| } | ||
| viewModel.deleteEmptyCards(report, keepNotes).join() | ||
| } |
Member
There was a problem hiding this comment.
Just to note: I'd like to move the launchCatchingTask into the ViewModel. Makes the calling code much cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 5
Purpose / Description
Adopt progress for DeckPicker i.e. the ViewModel reports its own progress and the fragment observes it
Fixes
withProgressin ViewModels #19460Approach
See commit
How Has This Been Tested?
Unit testing only
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.