Skip to content

feat: bottom nav screen views - #21859

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
criticalAY:feat/bottom-nav-screen-views
Sep 29, 2026
Merged

feat: bottom nav screen views#21859
criticalAY merged 1 commit into
ankidroid:mainfrom
criticalAY:feat/bottom-nav-screen-views

Conversation

@criticalAY

@criticalAY criticalAY commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Assisted-by: Opus 5 (tests)

Purpose / Description

  • Switching tabs sends nothing, and coming back to the app while a tab is open reports DeckPicker instead of that tab. feat: Add wiring and analytics for bottom nav bar #21274 only added analytics to the More tab's rows. Once the bar replaces the drawer, Card Browser and Statistics views from phones would quietly vanish from GA4, which would look like people had stopped using those screens.

Fixes

NA

Approach

Added the names i.e. see commits

How Has This Been Tested?

Added tests

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY added the Blocked by dependency Currently blocked by some other dependent / related change label Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Snapshot diff report: Previous regressions were resolved by the latest commit.

@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 0afb384 to 223bf03 Compare September 15, 2026 19:19
david-allison
david-allison reviewed Sep 15, 2026
View reviewed changes

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ping me to re-review when the changes in the base PR are applied here

@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 223bf03 to 8ec0435 Compare September 16, 2026 02:34
@david-allison

david-allison commented Sep 16, 2026

Copy link
Copy Markdown
Member

@criticalAY awaiting a de-conflict, then likely a very quick review 😄

@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 8ec0435 to 9d87416 Compare September 16, 2026 18:38
@criticalAY criticalAY removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels Sep 16, 2026
@criticalAY

criticalAY commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

All set now

@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 9d87416 to 93664ab Compare September 16, 2026 19:00
david-allison
david-allison approved these changes Sep 16, 2026
View reviewed changes

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 16, 2026
lukstbit
lukstbit approved these changes Sep 20, 2026
View reviewed changes

@lukstbit lukstbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question, but feel free to merge.

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/BottomNavController.kt Outdated
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 20, 2026
@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 20, 2026
@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 93664ab to 157ce53 Compare September 28, 2026 21:03
@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Sep 28, 2026
@criticalAY
criticalAY added this pull request to the merge queue Sep 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 28, 2026
@criticalAY
feat(bottom-nav): report tab screen views
7892d9a 
Switching tabs never sent a screen view, since no activity resumes.
Report each tab when it opens and when you come back to it.

Assisted-by: Claude Opus 5 [helped with tests]
@criticalAY
criticalAY force-pushed the feat/bottom-nav-screen-views branch from 157ce53 to 7892d9a Compare September 29, 2026 05:46
@criticalAY
criticalAY added this pull request to the merge queue Sep 29, 2026
Merged via the queue into ankidroid:main with commit 7a91a4a Sep 29, 2026
23 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 29, 2026
@github-actions github-actions Bot added this to the 2.26 release milestone Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes
@david-allison david-allison david-allison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.26 release

Development

Successfully merging this pull request may close these issues.

3 participants

@criticalAY @david-allison @lukstbit