Skip to content

refactor(deck-picker): move delete preparation to ViewModel - #22162

Merged
david-allison merged 2 commits into
ankidroid:mainfrom
david-allison:deckpicker-more-vm
Sep 29, 2026
Merged

david-allison merged 2 commits into
ankidroid:mainfrom
david-allison:deckpicker-more-vm

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6

Purpose / Description

low priority work, far future prep for Compose

How Has This Been Tested?

Tests added

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

(showing the confirmation for deleting a deck)

Assisted-by: GPT-6
@david-allison david-allison added Priority-Low cleanup Non functional change that would improve the code readability and removed Priority-Low labels Sep 28, 2026

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

}

@Test
fun `Delete shortcut requests confirmation only in tablet layout`() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nice

@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 29, 2026
@david-allison
david-allison added this pull request to the merge queue Sep 29, 2026
Merged via the queue into ankidroid:main with commit 0cad914 Sep 29, 2026
23 of 27 checks passed
@github-actions github-actions Bot removed the Needs Second Approval Has one approval, one more approval to merge label Sep 29, 2026
@github-actions github-actions Bot added this to the 2.26 release milestone Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Non functional change that would improve the code readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants