chore: prepare 0.4.3-fork.1 pre-release - #35
Merged
Conversation
The project still carried 0.4.3-SNAPSHOT, upstream's placeholder for its next version. Publishing an asset under that name would say two wrong things at once: SNAPSHOT means unreleased and mutable, and 0.4.3 alone is indistinguishable from a future upstream release. The six modules now read 0.4.3-fork.1. Nothing downstream needed editing. Maven filtering already carried the version into the archive name, the jars, the launcher scripts and evergreen.properties, and a build confirms all of them: the archive is studio-web-ui-0.4.3-fork.1-dist.zip, the scripts reference the jars it actually contains, the application reports 0.4.3-fork.1 and a new provenance record carries it as its converter version. The error toast offered to file a bug against marian-m12l/studio. It is rendered from twenty-five places, so it reaches a tester on their first failure, and it would have sent this fork's reports to a maintainer who did not write this code. It now points at this repository, whose issue templates it already relies on. Evergreen is untouched on purpose: the release check and the announce still read upstream, which is known and recorded as a non-blocking reserve rather than fixed opportunistically here. No behaviour change. Seven lines: six version numbers and one URL. Test counts unchanged: 282 Java, 57 JavaScript. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven lines: six version numbers and one URL.
Version
0.4.3-SNAPSHOT— upstream's placeholder for its next version — becomes0.4.3-fork.1across the six modules.SNAPSHOTmeans unreleased and mutable, which is the opposite of a published asset, and0.4.3alone is indistinguishable from a future upstream release.Only the parent's own version and the five
<parent>references changed: no module declares its own version, and every inter-module dependency already uses${project.version}.Propagation, verified in the artifact rather than assumed
Nothing downstream needed editing — Maven filtering carries the version everywhere.
mvn clean installconfirms:0.4.3-fork.1on all six modulesstudio-web-ui-0.4.3-fork.1-dist.zipstudio-web-ui-0.4.3-fork.1.jarstudio-agent-/studio-metadata-0.4.3-fork.1-jar-with-dependencies.jarevergreen.propertiesversion=0.4.3-fork.1, in the delivered jarApplicationVersion.current()0.4.3-fork.1converterVersion 0.4.3-fork.1The application version was measured against the delivered jar by reproducing
ApplicationVersion's own code path, with a negative control: without the jar on the classpath the same check reportsunknown, so it reads the resource rather than printing a constant.ConversionProvenanceTest.converterVersionIsTheApplicationVersion— which deliberately asserts againstApplicationVersion.current()rather than a hardcoded string — ties the provenance record to that value.No
0.4.3-SNAPSHOTleft in the archive: zero in the three scripts, zero inevergreen.properties, zero in the file names.Issue tracker
The error toast offered to file a bug against
marian-m12l/studio. It is rendered from twenty-five places, so it reaches a tester on their first failure, and it would have sent this fork's reports to a maintainer who did not write this code.It now points at this repository. Verified rather than assumed: issues are enabled here,
bug_report_en.mdandbug_report_fr.md— the two languages the component can request — are present in.github/ISSUE_TEMPLATE/, and both URLs resolve.The component, its text, its template and its twenty-five callers are unchanged. Zero occurrences of
marian-m12l/studio/issuesremain; upstream attribution links elsewhere are untouched.Evergreen left intact
Deliberately not changed, despite the constants sitting nearby: the release check, the announce fetch and
GITHUB_API_ROOTstill read upstream. That is a known, recorded non-blocking reserve, not something to fix opportunistically in a versioning lot.Scope
No behaviour change. No README, no
TESTING.md, noFIELD-VALIDATION.md, no workflow, no business logic, no tag, no release.Three
0.4.3-SNAPSHOToccurrences remain inFIELD-VALIDATION.mdand are left alone on purpose: they record the build actually used in past field sessions, and rewriting them would turn a true record into a false one.Test counts unchanged: 282 Java (14 skipped), 57 JavaScript.
BUILD SUCCESS.🤖 Generated with Claude Code