Stop setting the deprecated manifest_type property on InputStream Adaptive 21+ - #715
Open
einanderson wants to merge 1 commit into
Open
Stop setting the deprecated manifest_type property on InputStream Adaptive 21+#715einanderson wants to merge 1 commit into
einanderson wants to merge 1 commit into
Conversation
…am Adaptive Since Kodi 21 InputStream Adaptive detects the manifest type by itself and logs Warning "inputstream.adaptive.manifest_type" property is deprecated and will be removed next Kodi version, the manifest type is now automatically detected for every playback. Kodi 22 removes the property entirely, so playback would break there. It is not dropped outright, because the add-on still supports Kodi 20, whose InputStream Adaptive does not detect the type yet. The property is now set only when the installed version is older than 21, using the existing inputstream_adpative_supports() version helper. Verified: the helper returns False for ISA 2.6.20 and 20.3.19 and True for 21.0.0, 21.5.21, 21.5.23.1 and 22.3.20, with the existing EXT-X-DISCONTINUITY feature unchanged. Live on Kodi 21.3 with ISA 21.5.21 the property is no longer set and the deprecation warning is gone (three occurrences before, none after), with playback unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputStream Adaptive 21 detects the manifest type by itself and logs this on every playback:
Kodi 22 removes the property entirely, so playback would break there.
The change
The property is not dropped outright, because the add-on still supports Kodi 20, whose
InputStream Adaptive does not detect the type yet. It is now set only below ISA 21, through the
existing
inputstream_adpative_supports()helper — same shape as the existingEXT-X-DISCONTINUITYfeature check.Verification
The helper returns
Falsefor ISA 2.6.20 and 20.3.19 andTruefor 21.0.0, 21.5.21, 21.5.23.1and 22.3.20; the existing
EXT-X-DISCONTINUITYbehaviour is unchanged.Live on Kodi 21.3 with ISA 21.5.21: the property is no longer set, the deprecation warning is gone
(three occurrences before, none after) and playback is unaffected.