ci: run PostgreSQL tests on Windows x64 - #4849
Merged
Merged
Conversation
amoeba
changed the title
amoeba
force-pushed
the
windows-postgresql-copy-tests
branch
from
October 2, 2026 20:05
b2e6882 to
6e99f88
Compare
Member
Author
|
Testing 83e95c3 in CI here. Will revert. |
Member
Author
|
New tests are green with the patch from #4847
Reverting that change. |
This reverts commit 83e95c3.
amoeba
changed the title
amoeba
marked this pull request as ready for review
October 2, 2026 21:32
Member
|
Ope, good catch. |
lidavidm
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables testing the PostgreSQL driver on Windows x64, in both the conda and vcpkg jobs. Previously we were just building the driver on Windows. I opted to just use the runner's in-built PostgreSQL installation to avoid having to use Docker which is slow. GitHub's windows-11-arm runner doesn't have PostgreSQL so we're still not testing the driver there.
This PR discovered three latent issues which are also fixed here:
posgresql_test.ccof"[0-9]{6}"fails on Windows because apparently the GTest regex engine doesn't support it. So we fall back to a less fancy regex as needed. I think I could've dones/__WIN32/_WIN32also but GPT6.1-Sol suggested this and it looks more portable.GPT6.1-Sol was used in the creation of this PR.