Conversation
This will only fix things going forward, and we'll eventually want some tool to correct past releases (possibly on an ongoing basis, e.g. because a page may stop existing and we'll want to point to the last version of the page or the replacement page as canonical instead). Closes apache#4854.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The tagged build command is invalid, and non-Sphinx API documentation remains without canonical links.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds canonical URLs for documentation generated from tagged releases.
Changes:
- Configures Sphinx canonical URLs through
ADBC_BASEURL. - Sets the canonical base URL for release-tag workflow builds.
| File | Description |
|---|---|
docs/source/conf.py |
Enables Sphinx canonical-link generation. |
.github/workflows/nightly-website.yml |
Selects canonical URLs for tagged releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lidavidm
marked this pull request as ready for review
October 5, 2026 07:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will only fix things going forward, and we'll eventually want some tool to correct past releases (possibly on an ongoing basis, e.g. because a page may stop existing and we'll want to point to the last version of the page or the replacement page as canonical instead).
Closes #4854.