fix(arrow-data): account for struct parent offsets - #10934
Merged
Jefffrey merged 2 commits intoSep 2, 2026
Conversation
Rich-T-kid
approved these changes
Sep 1, 2026
Rich-T-kid
suggested changes
Sep 1, 2026
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
This PR seems to have introduces a bug in test_struct_array_from_data_with_offset_and_length_error
jaideeppyne
force-pushed
the
fix/struct-arraydata-parent-offset
branch
from
September 1, 2026 14:59
bbd1db5 to
79b9203
Compare
Contributor
Author
|
Fixed in 79b9203. I updated the struct ArrayData offset/length regression expectation so it now asserts the new validation error instead of expecting the old late panic. Local validation passed ( |
Contributor
Author
|
Thanks for the review. |
Jefffrey
reviewed
Sep 2, 2026
Jefffrey
approved these changes
Sep 2, 2026
Contributor
|
thanks @jaideeppyne & @Rich-T-kid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10933.
Struct
ArrayDataparent offsets compose with child offsets, but a few paths were still treating child data as if parent offset were always zero. This updates:offset + lenchild elementsparent_offset + logical_startMutableArrayDataextension to copy from the parent-offset-adjusted child rangeThe regression tests cover the concrete cases from #10933: validation, equality, and
MutableArrayData::try_extend.Validation run locally: