perf(arrow-select): add take_record_batch_unchecked to skip redundant bounds checks by Rich-T-kid · Pull Request #10945 · apache/arrow-rs

Rich-T-kid · 2026-09-01T18:30:00Z

#10945 <- here, this PR is stacked on top of #10944
#10944

Which issue does this PR close?

Closes Reduce bound checks in take kernels #8879.
the only unique commit compared to perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive #10944 is 47e2de0

Rationale for this change

take_record_batch previously called take per column, which always runs a bounds check on every index even when the caller already knows the indices are valid. For workloads doing repeated record batch takes with pre-validated indices — such as sort, merge, or filter pipelines — this check is redundant and measurable overhead. Benchmarks show ~13% speedup on primitive-column batches at 1024 rows when the check is skipped.

What changes are included in this PR?

Introduces pub unsafe fn take_record_batch_unchecked which bypasses index bounds checking by dispatching through take_impl::<_, false> directly

Are these changes tested?

yes, existing test + miri

Are there any user-facing changes?

new take_record_batch_unchecked() method.

Rich-T-kid · 2026-09-01T18:33:33Z

run benchmark take_kernel

adriangbot · 2026-09-01T18:35:30Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5498580695-2065-v7jf2 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (47e2de0) to 27a6a40 (merge-base) diff

Run configuration

run benchmark take_kernel

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-01T18:35:39Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

Rich-T-kid · 2026-09-01T19:31:34Z

run benchmark take_kernel

adriangbot · 2026-09-01T19:34:12Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5499301598-2066-x9drv 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (47e2de0) to 27a6a40 (merge-base) diff

Run configuration

run benchmark take_kernel

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-01T19:34:20Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

Jefffrey · 2026-09-02T01:37:25Z

-        .map(|c| take(c, indices, None))
-        .collect::<Result<Vec<_>, _>>()?;
-    RecordBatch::try_new(record_batch.schema(), columns)
+    unsafe { take_record_batch_unchecked(record_batch, indices) }


i think this is only safe when doing it on subsequent columns after the first column; the idea being that after doing (checked) take on the first column, we know for the next columns all indices are within bounds (otherwise wouldve panicked) since invariant of record batch is all columns are of same length

ah this is my mistake, was rushing when I pushed this and forgot to revert this. this was only placed here to compare the existing benchmarks.

the point of introducing the unsafe take_record_batch_unchecked was to allow users to opt into the unsafe code clearly, forcing them to add in unsafe blocks to their code.

will remove

ill push the update after we can view the benchmark results, from @adriangbot

Jefffrey · 2026-09-02T01:37:58Z

seems like take kernels are too big by now to run all at once; we'll need to run with filters 🤔

Rich-T-kid · 2026-09-02T01:54:47Z

run benchmark take_kernel
env:
BENCH_FILTER: record batch

adriangbot · 2026-09-02T01:57:50Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5503165150-2075-25gpc 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (47e2de0) to 27a6a40 (merge-base) diff

Run configuration

run benchmark take_kernel
env:
  BENCH_FILTER: "record batch"

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-02T01:57:56Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

Rich-T-kid · 2026-09-02T02:03:52Z

run benchmark take_kernel
env:
BENCH_FILTER: take_record_batch

adriangbot · 2026-09-02T02:03:54Z

Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10945 (comment)).

Error: invalid configuration: unknown field BENCH_FILTER, expected one of env, baseline, changed at line 2 column 1

Usage:

run benchmark <name>           # run specific benchmark(s)
run benchmarks                 # run default suite
run benchmarks <name1> <name2> # run specific benchmarks

Any benchmark name is accepted: bench.sh suite names (e.g. tpch, clickbench_partitioned, wide_schema) and Criterion bench targets (e.g. sql_planner) are resolved automatically. A name that matches neither fails on the runner.

Per-side configuration (run benchmark tpch followed by):

env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2G

File an issue against this benchmark runner

Rich-T-kid · 2026-09-02T02:04:06Z

run benchmark take_kernel
env:
BENCH_FILTER: take_record_batch

adriangbot · 2026-09-02T02:07:08Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5503236972-2076-csjjw 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (47e2de0) to 27a6a40 (merge-base) diff

Run configuration

run benchmark take_kernel
env:
  BENCH_FILTER: "take_record_batch"

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-02T02:07:15Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

Rich-T-kid · 2026-09-02T03:10:07Z

run benchmark take_kernel
env:
BENCH_FILTER: take_record_batch

adriangbot · 2026-09-02T03:13:09Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5503740178-2077-gghns 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (47e2de0) to 27a6a40 (merge-base) diff

Run configuration

run benchmark take_kernel
env:
  BENCH_FILTER: "take_record_batch"

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-02T03:13:15Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

Rich-T-kid · 2026-09-02T03:30:50Z

show benchmark queue

adriangbot · 2026-09-02T03:30:51Z

Hi @Rich-T-kid, you asked to view the benchmark queue (#10945 (comment)).

No pending jobs.

File an issue against this benchmark runner

Rich-T-kid · 2026-09-02T04:16:07Z

run benchmark take_kernel
env:
BENCH_FILTER: take_record_batch

adriangbot · 2026-09-02T04:19:09Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5504289314-2078-znlns 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (176446c) to 6e728ce (merge-base) diff

Run configuration

run benchmark take_kernel
env:
  BENCH_FILTER: "take_record_batch"

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-02T04:19:15Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

…cked

Rich-T-kid · 2026-09-02T13:13:11Z

run benchmark take_kernel
env:
BENCH_FILTER: take_record_batch

adriangbot · 2026-09-02T13:16:43Z

🤖 Arrow criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5510098487-2081-zx4gw 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing rich-T-kid/introduce-take_record_batch_unchecked (03d57b2) to 027b45f (merge-base) diff

Run configuration

run benchmark take_kernel
env:
  BENCH_FILTER: "take_record_batch"

BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-09-02T13:16:50Z

Benchmark for this request failed before finishing (Kubernetes reason: BackoffLimitExceeded).

Benchmarks requested: take_kernel

Kubernetes message

Job has reached the specified backoff limit

File an issue against this benchmark runner

github-actions Bot added arrow Changes to the arrow crate arrow-select labels Sep 1, 2026

Rich-T-kid mentioned this pull request Sep 1, 2026

perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive #10944

Open

Rich-T-kid changed the title ~~Rich t kid/introduce take record batch unchecked~~ perf(arrow-select): add take_record_batch_unchecked to skip redundant bounds checks Sep 1, 2026

Jefffrey reviewed Sep 2, 2026

View reviewed changes

Jefffrey added the performance label Sep 2, 2026

Rich-T-kid added 3 commits September 1, 2026 23:06

minor:change varible name to validate_indices

9175099

thread remaining VALIDATE_INDDICES callsites

b7d1fa4

resolve merge conflicts

06c0767

Rich-T-kid added 2 commits September 1, 2026 23:10

feat: introduce take_record_batch_unchecked

372a6b2

revert take_record_batch

176446c

Rich-T-kid force-pushed the rich-T-kid/introduce-take_record_batch_unchecked branch from 47e2de0 to 176446c Compare September 2, 2026 03:13

Merge branch 'main' into rich-T-kid/introduce-take_record_batch_unche…

03d57b2

…cked

Uh oh!

Conversation

Rich-T-kid commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Rich-T-kid commented Sep 1, 2026

Uh oh!

adriangbot commented Sep 1, 2026

Uh oh!

adriangbot commented Sep 1, 2026

Uh oh!

Rich-T-kid commented Sep 1, 2026

Uh oh!

adriangbot commented Sep 1, 2026

Uh oh!

adriangbot commented Sep 1, 2026

Uh oh!

Jefffrey Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Rich-T-kid Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Rich-T-kid Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jefffrey commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Rich-T-kid commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

adriangbot commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rich-T-kid commented Sep 1, 2026 •

edited

Loading

Rich-T-kid Sep 2, 2026 •

edited

Loading