Skip to content

Remove force_validate feature from arrow-cast #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jefffrey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove force_validate feature from arrow-cast #10950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion arrow-cast/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ all-features = true

[features]
prettyprint = ["comfy-table"]
force_validate = []

[dependencies]
arrow-array = { workspace = true }
Expand Down
2 changes: 0 additions & 2 deletions arrow-cast/src/cast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3027,7 +3027,6 @@ mod tests {
}

#[test]
#[cfg(not(feature = "force_validate"))]
#[should_panic(
expected = "Cannot cast to Decimal128(20, 3). Overflowing on 57896044618658097711785492504343953926634992332820282019728792003956564819967"
)]
Expand Down Expand Up @@ -3064,7 +3063,6 @@ mod tests {
}

#[test]
#[cfg(not(feature = "force_validate"))]
fn test_cast_decimal_to_decimal_round() {
let array = vec![
Some(1123454),
Expand Down
Loading