GH-50251- Add GetSpan to ArrayData#50366
Open
dkp116 wants to merge 4 commits into
Open
Conversation
|
|
pitrou
reviewed
Jul 6, 2026
| TEST_F(TestArray, GetSpanRespectsOffset) { | ||
| auto data_buffer = Buffer::FromString("123456789abcdef0"); | ||
| auto data = ArrayData::Make(uint8(), 3, {nullptr, data_buffer}, 0, 1); | ||
| auto span = data->GetSpan<uint8_t>(1, 3); |
Member
There was a problem hiding this comment.
Can you test with a non-byte sized data type?
Comment on lines
+1156
to
+1157
| auto data = ArrayData::Make(uint8(), 3, buffers, 0, 1); | ||
| auto span = data->template GetMutableSpan<uint8_t>(1, 3); |
| EXPECT_EQ(span[0], '2'); | ||
| EXPECT_EQ(span[1], '3'); | ||
| EXPECT_EQ(span[2], '4'); | ||
| } |
Member
There was a problem hiding this comment.
Nit: please leave an empty line after each test function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
( #50251 ) Enhancement for ArrayData
What changes are included in this PR?
Added GetSpan(int i, int64_t length) for read-only typed access to ArrayData.
Added GetMutableSpan(int i, int64_t length) for writable typed access to ArrayData.
Are these changes tested?
New unit tests were added in array_test.cc:
GetSpanRespectsOffset
GetMutableSpanRespectsOffset
The tests verify:
correct slicing with offset
correct span length
correctness of data read through spans
correctness of in-place mutation through GetMutableSpan