Add Guest OS mapping for windows server 2025 on VMware#12358
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12358 +/- ##
=========================================
Coverage 18.10% 18.10%
- Complexity 16742 16745 +3
=========================================
Files 6037 6037
Lines 542887 542887
Branches 66480 66480
=========================================
+ Hits 98279 98289 +10
+ Misses 433561 433551 -10
Partials 11047 11047
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16233 |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, but should this not go on earlier versions than 23?
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
| UPDATE `cloud`.`configuration` SET value='firstfit' WHERE name IN ('vm.allocation.algorithm', 'volume.allocation.algorithm') AND value='userconcentratedpod_firstfit'; | ||
|
|
||
| -- Add Windows Server 2025 guest OS and mappings | ||
| CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (6, 'Windows Server 2025 (64-bit)', 'VMware', '7.0', 'windows2022srvNext_64Guest'); |
There was a problem hiding this comment.
At some point we should stop using constant category IDs as they are dynamic now
There was a problem hiding this comment.
today is a good day to die… ;)
There was a problem hiding this comment.
@shwstppr
do you have any advice how to improve it to use dynamic category ID instead of hardcoded ID ?
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
this is a minor guest os support, can we move to schema-42200to42210.sql ?
|
@Pearl1594 can you please address the conflicts? |
|
@Pearl1594 |
|
@Pearl1594 can you resolve the conflicts , will test it for the 4.23 release Hitting the issue on the recent 4.22 |
…025-vmware-os-mapping
|
I believe this could still be relevant @weizhouapache . |
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17992 |
|
|
@Pearl1594 |
|
thanks @Pearl1594 for the fix
I think some improvements are needed when register template, update template or update vm with new Guest OS type, it would be better to check if the guest OS is supported by the hypervisor and version (it seems complicated) We need to be careful when add a new Guest OS (for example ubuntu 26.04 #13465) |
7 participants
Description
This PR adds guest os and mappings for Windows Server 2025
Addresses: #12324
Deployed a new virtual machine on vmware 8.0.3 and set the guest os to Windows server 2025 and found the mapping
on ESXi host - the guest os it guest mapped to is
windows2022srvNext_64GuestTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
VM OS Type
ISO registered with OS type Windows Server 2025:
How did you try to break this feature and the system with this change?