chore: deprecate record_batch macro in favor of upstream one

[buraksenn]

Which issue does this PR close?

• Closes Remove record_batch! macro once upstream updates #13037.

Rationale for this change

This was a long standing thing in the backlog. record_batch! was added in arrow; however, it did not support vectors. Then I've created a PR in arrow a while ago apache/arrow-rs#9522. Once that was released this macro can be deprecated

What changes are included in this PR?

Mark record_batch! macro deprecated and use arrow one in relevant places.

Are these changes tested?

Yes

Are there any user-facing changes?

Users will see a deprecation notice if they are using this macro

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

     Cloning apache/main
    Building datafusion v54.0.0 (current)
       Built [ 103.976s] (current)
     Parsing datafusion v54.0.0 (current)
      Parsed [   0.035s] (current)
    Building datafusion v54.0.0 (baseline)
       Built [ 100.490s] (baseline)
     Parsing datafusion v54.0.0 (baseline)
      Parsed [   0.034s] (baseline)
    Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.601s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 206.739s] datafusion
    Building datafusion-common v54.0.0 (current)
       Built [  33.718s] (current)
     Parsing datafusion-common v54.0.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-common v54.0.0 (baseline)
       Built [  33.379s] (baseline)
     Parsing datafusion-common v54.0.0 (baseline)
      Parsed [   0.061s] (baseline)
    Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.697s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure macro_marked_deprecated: macro #[deprecated] added ---

Description:
A `macro_rules!` declarative macro is now #[deprecated]. Downstream crates will get a compiler warning when using this macro.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/macro_marked_deprecated.ron

Failed in:
  macro record_batch in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:382

     Summary semver requires new minor version: 0 major and 1 minor checks failed
    Finished [  69.114s] datafusion-common
    Building datafusion-datasource v54.0.0 (current)
       Built [  36.953s] (current)
     Parsing datafusion-datasource v54.0.0 (current)
      Parsed [   0.030s] (current)
    Building datafusion-datasource v54.0.0 (baseline)
       Built [  36.223s] (baseline)
     Parsing datafusion-datasource v54.0.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.249s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  74.730s] datafusion-datasource
    Building datafusion-datasource-parquet v54.0.0 (current)
       Built [  41.773s] (current)
     Parsing datafusion-datasource-parquet v54.0.0 (current)
      Parsed [   0.029s] (current)
    Building datafusion-datasource-parquet v54.0.0 (baseline)
       Built [  42.024s] (baseline)
     Parsing datafusion-datasource-parquet v54.0.0 (baseline)
      Parsed [   0.031s] (baseline)
    Checking datafusion-datasource-parquet v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.150s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  85.074s] datafusion-datasource-parquet
    Building datafusion-ffi v54.0.0 (current)
       Built [  57.330s] (current)
     Parsing datafusion-ffi v54.0.0 (current)
      Parsed [   0.059s] (current)
    Building datafusion-ffi v54.0.0 (baseline)
       Built [  57.816s] (baseline)
     Parsing datafusion-ffi v54.0.0 (baseline)
      Parsed [   0.062s] (baseline)
    Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.251s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 116.746s] datafusion-ffi
    Building datafusion-physical-expr-adapter v54.0.0 (current)
       Built [  30.347s] (current)
     Parsing datafusion-physical-expr-adapter v54.0.0 (current)
      Parsed [   0.009s] (current)
    Building datafusion-physical-expr-adapter v54.0.0 (baseline)
       Built [  30.382s] (baseline)
     Parsing datafusion-physical-expr-adapter v54.0.0 (baseline)
      Parsed [   0.009s] (baseline)
    Checking datafusion-physical-expr-adapter v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.089s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  61.720s] datafusion-physical-expr-adapter

[Jefffrey]

this seems pretty unfortunate, that its kind of a hidden dependency of the macro 🙁

i suppose we cant do much about it unless we fix it upstream (and even then would require arrow-array to reexport arrow-schema i think?)

[buraksenn]

Yes, I was kinda surprised this was required as well. If you think this is a blocker I can close and just leave record_batch! as it is I'm not sure what is best

[Jefffrey]

yeah i think it's a bit awkward to need to import two dependencies in order to use this macro 🤔