Skip to content

ci: reintroduce code coverage reporting with cargo-llvm-cov#23336

Draft
buraksenn wants to merge 1 commit into
apache:mainfrom
buraksenn:reintroduce-code-coverage-with-llvm-cov
Draft

ci: reintroduce code coverage reporting with cargo-llvm-cov#23336
buraksenn wants to merge 1 commit into
apache:mainfrom
buraksenn:reintroduce-code-coverage-with-llvm-cov

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Code coverage has been disabled since #3678. The reason was it failed because of sql_integration test binary. This PR reintroduces it

What changes are included in this PR?

Reintroduce code coverage

Are these changes tested?

Not yet I need to test if tokenless coverage upload works described in https://about.codecov.io/blog/tokenless-uploads-for-github-actions/. If not I'll create a PR in my fork https://github.com/buraksenn/datafusion

Are there any user-facing changes?

no

@github-actions github-actions Bot added development-process Related to development process of DataFusion core Core DataFusion crate ffi Changes to the ffi crate labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion v54.0.0 (current)
       Built [ 103.067s] (current)
     Parsing datafusion v54.0.0 (current)
      Parsed [   0.035s] (current)
    Building datafusion v54.0.0 (baseline)
       Built [ 104.111s] (baseline)
     Parsing datafusion v54.0.0 (baseline)
      Parsed [   0.036s] (baseline)
    Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.597s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 209.243s] datafusion
    Building datafusion-ffi v54.0.0 (current)
       Built [  59.405s] (current)
     Parsing datafusion-ffi v54.0.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-ffi v54.0.0 (baseline)
       Built [  61.559s] (baseline)
     Parsing datafusion-ffi v54.0.0 (baseline)
      Parsed [   0.062s] (baseline)
    Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.226s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/feature_missing.ron

Failed in:
  feature tarpaulin_include in the package's Cargo.toml

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [ 122.513s] datafusion-ffi

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change core Core DataFusion crate development-process Related to development process of DataFusion ffi Changes to the ffi crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage jobs are failing on master: Failed to compile tests! Error: sql_integration: linking with cc failed: exit status: 1"

1 participant