[filesystem] avoid zero-skip loop in HadoopDataInputStream#3738
Draft
wolfkill wants to merge 1 commit into
Draft
[filesystem] avoid zero-skip loop in HadoopDataInputStream#3738wolfkill wants to merge 1 commit into
wolfkill wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718.
Root Cause
HadoopDataInputStream.seek()optimizes small forward seeks by callingskipFully(delta)instead of issuing a Hadoopseek().skipFully()assumed everyFSDataInputStream.skip(bytes)call makes forward progress. Some streams return0at EOF or when no bytes can currently be skipped. In that casebytesnever decreases and the loop can spin forever instead of letting the underlying filesystem handle the requested target position.Changes
skipFully.skip()returns0or a negative value, fall back toforceSeek(seekPos)and return.Validation
JAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -Dtest=HadoopDataInputStreamTest#testSeekFallsBackWhenSkipMakesNoProgress -DfailIfNoTests=false testfailed before the fix becauseskip()was retried after making no progress.JAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -Dtest=HadoopDataInputStreamTest#testSeekFallsBackWhenSkipMakesNoProgress -DfailIfNoTests=false testJAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -Dtest=HadoopDataInputStreamTest -DfailIfNoTests=false testJAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -DfailIfNoTests=false testgit diff --check