[ISSUE-851] implemented VectorStore and VectorStoreMetadata interfaces with validation and persistence - #855
Open
Sumit2342 wants to merge 1 commit into
Open
Conversation
…s with validation and persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses issue [#851 ] by defining the VectorStore SPI and VectorStoreMetadata contract for the geaflow-ai module.
Major changes include:
• Created the generic VectorStore interface to define standard vector operations (add, delete, search, init).
• Added VectorStoreMetadata with required fields (model_name, dimension, distance, index_version, created_at, format_version) and local fixture
persistence using Gson.
• Implemented strict metadata validation that throws IllegalArgumentException on dimension mismatch, missing metadata, or model
mismatch.
How was this PR tested?
[✓] Tests have Added for the changes
[ ] Production environment verified
Added the VectorStoreMetadataTest which systematically verifies:
• Saving and loading the metadata to/from the JSON local fixture.
• Exception throwing when required fields are missing during validation.
• Exception throwing when testing against dimension or model mismatches.