fix(table): resolve dropped equality fields from schema history - #1952
Open
mattfaltyn wants to merge 1 commit into
Open
fix(table): resolve dropped equality fields from schema history#1952mattfaltyn wants to merge 1 commit into
mattfaltyn wants to merge 1 commit into
Conversation
Signed-off-by: Matt Faltyn <faltyn.matthew@gmail.com>
mattfaltyn
marked this pull request as ready for review
August 28, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1951.
Summary
Why
Equality delete files retain stable table field IDs after schema evolution. The reader previously resolved those IDs only against the current schema, so dropping a live equality key made affected scans fail before filtering.
Using the newest historical schema that contains the delete file's complete key preserves field identity and keeps the current result projection unchanged.
Testing
go test ./table -run '^TestEqualityDeleteReadRoundTrip$' -count=2 -vgo test ./table -run 'EqualityDelete' -count=1go test -race ./table -run '^TestEqualityDeleteReadRoundTrip$' -count=1go vet ./tablemake testmake lintmake test-racemake test-assert