Optimize parent controller path retrieval in JMeterThread#6721
Open
rajat315315 wants to merge 1 commit into
Open
Optimize parent controller path retrieval in JMeterThread#6721rajat315315 wants to merge 1 commit into
rajat315315 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6720
Description
This PR introduces a thread-local parent controller path cache (
parentControllersCache) insideJMeterThread.Specifically, the changes are:
HashMapmappingSamplertoList<Controller>inJMeterThread.CachedPathToRootTraverserextendingFindTestElementsUpToRootTraverserto bypass tree walks on cache hits.triggerLoopLogicalActionOnParentControllersto lookup resolved paths in the cache and save the path on a cache miss.Motivation and Context
When a sampler execution fails with the
onErrorStartNextLoopoption enabled, or when loop logical actions (such as Break/Continue) are triggered, JMeter traverses the entire test tree using DFS (testTree.traverse()) from the sampler to the root to resolve parent controllers.For large test plans with deep nesting, this full tree walk is redundant since the test tree's hierarchy is static during thread execution. Under error-heavy loads, these continuous traversals degrade performance and spike CPU usage. Caching the path to the root per-sampler inside each thread avoids this overhead entirely.
How Has This Been Tested?
Created a microbenchmark simulating a deeply nested test plan structure (10 nested levels of loop controllers) over 100,000 iterations:
292.57 ms30.68 msCompiled core module Java classes using
./gradlew :src:core:compileJava.Executed the core test suite using
./gradlew :src:core:test(379 tests completed, 0 failed, 1 skipped).Screenshots (if appropriate):
N/A (performance optimization)
Types of changes
Checklist: