[MPH-217] Ensure packaging is always shown in effective-pom output - #405
Open
elharo wants to merge 1 commit into
Open
[MPH-217] Ensure packaging is always shown in effective-pom output#405elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
MavenXpp3Writer omits the packaging element when it is null or equals the default value 'jar'. This leads help:effective-pom to not show the packaging at all when it is not explicitly set in the POM. Fix: after serialization, insert the packaging element into the XML output if missing. This ensures users can always see the effective packaging value (e.g. jar, pom, war) in the effective POM output. Includes an integration test with a POM that has no packaging element, verifying the output contains <packaging>jar</packaging>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
help:effective-pomdoes not show the<packaging>element when the packaging is not explicitly set in the POM (defaulting tojar).MavenXpp3Writerintentionally omits the<packaging>element when it isnullor equals"jar"(the default), so users cannot see the effective packaging value.Fix: After serialization, detect if the
<packaging>element is missing and insert it into the XML output if so. This ensures the effective packaging value is always visible.Test: Added an integration test (
effective-pom-packaging) with a POM that has no<packaging>element, verifying the output contains<packaging>jar</packaging>.Fixes #332