Warning mode, diagnostic collector, BuilderProblem enrichments - #12698
Open
gnodet wants to merge 1 commit into
Open
Warning mode, diagnostic collector, BuilderProblem enrichments#12698gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
This was referenced Aug 7, 2026
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 01:23
b0617f7 to
1a419b7
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 01:23
0cc76eb to
6124231
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Aug 8, 2026
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 05:35
6124231 to
dc3bccd
Compare
gnodet
force-pushed
the
feature/console-modes
branch
2 times, most recently
from
August 8, 2026 12:14
1e4c616 to
eb4b145
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 12:14
dc3bccd to
a7c83db
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 19:17
eb4b145 to
35cf036
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 19:17
a7c83db to
7243fd7
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 19:35
35cf036 to
e06f638
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 19:35
7243fd7 to
af945c2
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
feature/console-modes
branch
from
August 8, 2026 21:48
e06f638 to
77ddf3a
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 8, 2026 21:48
af945c2 to
850a04c
Compare
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
Aug 8, 2026
Add the mvnlog tool for viewing and analyzing build-report JSON files. Includes BuildReportRenderer for human-readable output, SimpleJsonReader for dependency-free JSON parsing, shell scripts (mvnlog/mvnlog.cmd), and --log routing in mvn/mvn.cmd. Also adds integration tests for build report generation, console modes, and the mvnlog viewer, plus --console=verbose flags for ITs that depend on verbose output. Part 5 of the #12572 split (depends on warning mode PR #12698). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
- --warning-mode=summary|all|none|fail CLI flag - BuilderProblem enrichments: getKey(), getSuggestion(), getDocumentationUrl() - INFO severity level added to BuilderProblem.Severity enum - DiagnosticReporter injectable service for plugins to report structured problems - DefaultDiagnosticCollector: thread-safe, deduplicating problem store - BuildReportCollector upgraded with full diagnostic integration
gnodet
force-pushed
the
feature/console-modes
branch
from
August 9, 2026 08:11
77ddf3a to
6b6fc7f
Compare
gnodet
force-pushed
the
feature/warning-mode
branch
from
August 9, 2026 08:11
850a04c to
5913a2b
Compare
gnodet
marked this pull request as ready for review
August 9, 2026 08:11
gnodet
commented
Aug 9, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
Well-structured diagnostic infrastructure with good test coverage. Two issues found after verification (a third finding about removed try-catch was a false positive — EventSpyDispatcher.onEvent() already provides the safety net).
Also noted:
- Two independent
BuilderProblemimplementations exist (privateDefaultProblemrecord inBuilderand publicDefaultBuilderProblemin impl). Future field additions need to update both. - The
warningModepropagation via user properties (maven.build.warningMode) is pragmatic for an EventSpy but worth noting as a side-channel.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
| String key = problem.getKey(); | ||
|
|
||
| // Problems without a key get a synthetic key for storage | ||
| if (key == null) { |
Contributor
Author
There was a problem hiding this comment.
Race condition: noKeyCounter.increment() and noKeyCounter.longValue() are not atomic together. Two concurrent threads reporting null-key problems can both get the same counter value, producing the same synthetic key "__no_key__N", and the second problem is silently dropped by putIfAbsent.
Fix: use AtomicLong instead of LongAdder with incrementAndGet() for an atomic unique counter:
Suggested change
| if (key == null) { | |
| key = "__no_key__" + noKeyCounter.incrementAndGet(); |
(also change noKeyCounter field type from LongAdder to AtomicLong)
| .get()); | ||
| options.addOption(Option.builder() | ||
| .longOpt(WARNING_MODE) | ||
| .hasArg() |
Contributor
Author
There was a problem hiding this comment.
No validation of --warning-mode values. An invalid value like --warning-mode=quiet is silently accepted and defaults to summary behavior. BaseParser.validate() already validates --color and --fail-on-severity against allowed values — --warning-mode should follow the same pattern for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 4 of the logging feature chain. Depends on #12697 (console modes).
Adds
--warning-modeCLI flag and structured diagnostic infrastructure:--warning-mode=summary(default) — deduplicated warning summary at end of build--warning-mode=all— inline warnings + summary--warning-mode=none— suppress diagnostic summary--warning-mode=fail— treat warnings as build errorsBuilderProblem API enrichments
getKey()— stable deduplication key for cross-module dedupgetSuggestion()— actionable fix suggestiongetDocumentationUrl()— link to relevant docsINFOseverity level added toSeverityenumBuilderProblem.builder()— fluent builder API withDefaultProblemrecordNew service API
DiagnosticReporter—@Inject-able service for plugins to report structured problemsInternal infrastructure
DefaultDiagnosticCollector— thread-safe, deduplicating problem store with suppression supportDefaultDiagnosticReporter/DefaultDiagnosticSummary— wiringBuildReportCollectorupgraded to useDefaultDiagnosticCollector, auto-collect WARN log events, print summaryFiles changed (16 files, ~1600 insertions)
BuilderProblemenrichments,DiagnosticReporter,Options(+warningMode())CommonsCliOptions,LayeredOptions,MavenInvokerBuildReportCollector(full diagnostic integration),BuildReportJsonWriter(problem enrichments)DefaultDiagnosticCollector,DefaultDiagnosticReporter,DefaultDiagnosticSummaryDefaultBuilderProblem(key/suggestion/url fields)DefaultDiagnosticCollectorTest)PR chain
mvnlogviewerTest plan
mvn test -pl impl/maven-core— all tests passmvn test -pl impl/maven-cli— all 692+ tests pass🤖 Generated with Claude Code