core-spec: move semantic_model out of the Enumerations section in spec.yaml

[eisber]

Summary

core-spec/spec.yaml is a multi-document YAML file whose --- separators group the
specification into sections. semantic_model is a document-root key, but it sits after the
# Enumerations separator, so it parses as a member of that section alongside the enum
definitions.

On main today:

>>> [list(d) for d in yaml.safe_load_all(open("core-spec/spec.yaml"))]
[['version'],
 ['dialects', 'datatypes', 'vendor_name', 'semantic_model'],   # <-- root key in # Enumerations
 ['datasets'],
 ['relationships'],
 ['fields'],
 ['metrics']]

This PR gives the document-root keys their own section, matching how every other section in
the file is delimited:

[['version'],
 ['dialects', 'datatypes', 'vendor_name'],
 ['semantic_model'],
 ['datasets'],
 ['relationships'],
 ['fields'],
 ['metrics']]

Scope

Five added lines, all of them a --- separator and comments. No key, value or enum member
is added, removed, renamed or reordered, so the parsed content of the file is unchanged
apart from which section semantic_model belongs to.

Nothing in the repository parses core-spec/spec.yaml — it is documentation. (The two
spec.yaml references under converters/ontology/tests/ are unrelated tmp_path fixtures.)
So this carries no runtime risk; it makes the file say what it already meant.

Noticed while preparing #323, and split out of it so that PR stays about one thing.

Related Issues

None.

Checklist

Specification

• Spec changes are included in core-spec/ and follow the existing structure
• Spec changes have been discussed on the mailing list or in a linked issue — not applicable, this is a comment-only sectioning fix with no semantic change
• Breaking changes to the spec are clearly called out in the summary — there are none

Ontology

• Ontology changes in ontology/ are consistent with spec changes — ontology/ is untouched
• New or modified terms are defined and documented — no terms added or modified

Converters

• Converter logic in converters/ is updated to reflect spec or ontology changes — not applicable, nothing parses this file
• New converters include tests under the converter's test directory — not applicable

Validation

• Validation rules in validation/ are updated if the spec changed — no change needed; validate.py reads ossie-schema.json, not spec.yaml
• New validation cases are covered by tests — not applicable; existing suites re-run green (test_validate.py 34 passed, validation/tests/ 10 passed)

Documentation

• docs/ is updated to reflect any user-facing changes — no user-facing change
• New features or behaviors are documented with examples where appropriate — no new behavior
• CONTRIBUTING.md is updated if the contribution process changed — not applicable

Examples

• examples/ are added or updated for any new spec constructs — no new constructs

Tests

• All existing tests pass (pytest / CI green)
• New functionality is covered by tests — no new functionality

Compliance

• ASF license headers are present on all new source files — no new files added
• No third-party dependencies are added without PMC/IPMC approval — none added

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	core-spec/​spec.yaml — The new “Document root” comment is potentially misleading in a multi-document YAML file:…

What changed in this PR

This PR adjusts the sectioning in core-spec/spec.yaml so semantic_model is separated into its own YAML document, preventing it from being grouped under the “Enumerations” section when parsed as a multi-document YAML file.

Changes:

• Inserted a --- document separator before semantic_model
• Added a short “Document root” comment block to clarify intent

File	Description
core-spec/​spec.yaml	Adds a new YAML document boundary + comments so semantic_model is no longer parsed within the Enumerations document

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.