HDDS-15726. Improve SCM block deletion summary error handling#10650
Open
ChenSammi wants to merge 1 commit into
Open
HDDS-15726. Improve SCM block deletion summary error handling#10650ChenSammi wants to merge 1 commit into
ChenSammi wants to merge 1 commit into
Conversation
priyeshkaratha
left a comment
priyeshkaratha
left a comment
Contributor
There was a problem hiding this comment.
Thank you @ChenSammi for working on this. Changes LGTM. Just have minor suggestion on newly added method name.
| deletedBlockLogStateManager.addTransactionsToDB(txList); | ||
| } | ||
|
|
||
| private void incrDeletedBlocksSummary(TxBlockInfo txBlockInfo) { |
Contributor
There was a problem hiding this comment.
since this method is used to do rollback, can we rename to something like restoreDeletedBlocksSummary
aryangupta1998
left a comment
aryangupta1998
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, @ChenSammi, some minor comments inline!
Comment on lines
+510
to
+513
| if (!scmContext.isLeaderReady()) { | ||
| LOG.warn("SCM is not ready to commit transactions."); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!scmContext.isLeaderReady()) { | |
| LOG.warn("SCM is not ready to commit transactions."); | |
| return; | |
| } | |
| if (!scmContext.isLeaderReady()) { | |
| LOG.debug("Skip commit transactions since SCM leader is not ready yet."); | |
| return; | |
| } |
onMessage() now logs at WARN for non-ready leader, this can spam logs during leader warm-up because this path is heartbeat-driven, can we change it to debug?
| totalBlockCount.addAndGet(txBlockInfo.getTotalBlockCount()); | ||
| totalBlocksSize.addAndGet(txBlockInfo.getTotalBlockSize()); | ||
| totalReplicatedBlocksSize.addAndGet(txBlockInfo.getTotalReplicatedBlockSize()); | ||
| LOG.debug("Increase summary for {} to {}", txBlockInfo, summaryToString(getSummary())); |
Contributor
There was a problem hiding this comment.
Suggested change
| LOG.debug("Increase summary for {} to {}", txBlockInfo, summaryToString(getSummary())); | |
| if (LOG.isDebugEnabled()) { | |
| LOG.debug("Increase summary for {} to {}", txBlockInfo, summaryToString(getSummary())); | |
| } |
Same we can do for,
descDeletedBlocksSummary(TxBlockInfo txBlockInfo)
descDeletedBlocksSummary(DeletedBlocksTransaction tx)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the block deletion summary error handing
What is the link to the Apache JIRA
HDDS-15726
How was this patch tested?
existing unit tests.