test: make InputStreamSource TCK publisher finite - #2999
Merged
Conversation
Motivation: JDK 25 nightly builds abort InputStreamSourceTest when the TCK cancellation scenario waits for completion from an infinite, CPU-busy InputStream publisher. Modification: Make the test publisher finite and emit one byte per ByteString so the TCK element count maps directly to stream elements without relying on take(elements) to stop a busy reader. Result: InputStreamSourceTest completes under JDK 25 nightly-style virtualized stream-dispatcher settings. Tests: - JDK 25 nightly-style virtualized stream-dispatcher flags: stream-tests-tck / Test / testOnly org.apache.pekko.stream.tck.InputStreamSourceTest - scalafmt --mode diff-ref=origin/main --quiet - scalafmt --list --mode diff-ref=origin/main - git diff --check References: Refs apache#2994
Member
|
related to #2904 ? |
Member
Author
|
I extracted it from there, we can check this later,as we recently fix the bug with varhandle |
132982jianan
pushed a commit
to 132982jianan/pekko
that referenced
this pull request
Aug 2, 2026
动机： 当 TCK 取消场景等待无限、CPU 繁忙的 InputStream 发布者完成时，JDK 25 每晚构建中止 InputStreamSourceTest。 修改： 使测试发布者有限并为每个 ByteString 发出一个字节，以便 TCK 元素计数直接映射到流元素，而不依赖 take(elements) 来阻止繁忙的读取器。 结果： InputStreamSourceTest 在 JDK 25 nightly-style 虚拟化流调度程序设置下完成。 测试： - JDK 25 nightly-style虚拟化流调度程序标志：stream-tests-tck / Test / testOnly org.apache.pekko.stream.tck.InputStreamSourceTest - scalafmt --mode diff-ref=origin/main --quiet - scalafmt --list --mode diff-ref=origin/main - git diff --检查 参考文献： 参考号apache#2994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JDK 25 nightly builds abort InputStreamSourceTest when the Reactive Streams TCK cancellation scenario waits for completion from an infinite, CPU-busy InputStream publisher.
Modification
Make the test publisher finite and emit one byte per ByteString so the TCK element count maps directly to stream elements without relying on take(elements) to stop a busy reader.
Result
The TCK publisher completes deterministically under JDK 25 nightly-style virtualized stream-dispatcher settings.
Tests
References
Refs #2994