test: clean up TLS edge streams after early cancellation - #3000
Merged
He-Pin merged 1 commit intoMay 28, 2026
Conversation
Motivation: JDK 25 nightly builds time out in repeated TlsGraphStageEdgeCasesSpec early-cancellation scenarios because earlier materializations can keep draining after the expected bytes have been collected. Modification: Materialize collectExactly with a KillSwitch and watch stream termination, then shut down and await the stream in finally after the expected bytes are collected. Result: Repeated TLS edge-case checks do not leave prior materializations running in the same actor system. Tests: - JDK 25 nightly-style virtualized stream-dispatcher flags: stream-tests / Test / testOnly org.apache.pekko.stream.io.TlsGraphStageEdgeCasesSpec - scalafmt --mode diff-ref=origin/main --quiet - scalafmt --list --mode diff-ref=origin/main - git diff --check References: Refs apache#2994
132982jianan
pushed a commit
to 132982jianan/pekko
that referenced
this pull request
Aug 2, 2026
动机： JDK 25 每晚构建在重复的 TlsGraphStageEdgeCasesSpec 提前取消场景中会超时，因为在收集到预期字节后，早期的实现可能会继续耗尽。 修改： 使用 KillSwitch 实现collectExactly 并观察流终止，然后在收集到预期字节后关闭并等待流。 结果： 重复的 TLS 边缘情况检查不会使先前的具体化在同一参与者系统中运行。 测试： - JDK 25 nightly-style虚拟化流调度程序标志：stream-tests / Test / testOnly org.apache.pekko.stream.io.TlsGraphStageEdgeCasesSpec - scalafmt --mode diff-ref=origin/main --quiet - scalafmt --list --mode diff-ref=origin/main - git diff --检查 参考文献： 参考号apache#2994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JDK 25 nightly builds time out in repeated TlsGraphStageEdgeCasesSpec early-cancellation scenarios because earlier materializations can keep draining after the expected bytes have been collected.
Modification
Materialize collectExactly with a KillSwitch and watch stream termination, then shut down and await the stream in finally after the expected bytes are collected.
Result
Repeated TLS edge-case checks do not leave prior materializations running in the same actor system.
Tests
References
Refs #2994