PHOENIX-7970 :- QueryDatabaseMetaDataIT.testShowTables fails after SYSTEM.HA_GROUP is added to the SYSTEM schema#2585
Open
lokiore wants to merge 1 commit into
Conversation
…STEM.HA_GROUP is added to the SYSTEM schema The consistent-failover work adds a new system table, SYSTEM.HA_GROUP, raising the SYSTEM schema table count from 12 to 13. testShowTables hard-codes the old count, so "SHOW TABLES IN SYSTEM" now fails with expected:<12> but was:<13>. Update the expected count to 13 and assert the returned set contains HA_GROUP so the test documents that the table is expected in the SYSTEM schema. Test-only change; no production code is affected. The "SHOW TABLES IN SYSTEM LIKE 'FUNC%'" assertion is unchanged. Generated-by: Claude Code (Opus 4.8 (1M context))
lokiore
changed the title
tkhurana
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem including root cause
The consistent-failover work on the
PHOENIX-7562-feature-newline adds a new system table,SYSTEM.HA_GROUP(PhoenixDatabaseMetaData.SYSTEM_HA_GROUP_TABLE), to the SYSTEM schema. This raises the number of tables in the SYSTEM schema from 12 to 13.QueryDatabaseMetaDataIT.testShowTableshard-codes the previous count when runningSHOW TABLES IN SYSTEM, so on this feature line it fails with:Fix
Test-only change:
12to13.assertTrue(tables.contains("HA_GROUP"))so the test documents thatSYSTEM.HA_GROUPis expected to be present.No production code is changed. The
SHOW TABLES IN SYSTEM LIKE 'FUNC%'assertion (expecting exactly one match,FUNCTION) is untouched.Tests
QueryDatabaseMetaDataIT#testShowTablesruns and passes locally on thePHOENIX-7562-feature-newbase (Tests run: 1, Failures: 0, Errors: 0).AI disclosure
Per the ASF generative-tooling policy, this change was produced with the assistance of generative AI. The commit carries the trailer
Generated-by: Claude Code (Opus 4.8 (1M context)). All changes were reviewed before submission.Notes / backward compatibility
No API, wire, or on-disk format changes; this is an integration-test assertion update scoped to the feature branch's new SYSTEM table. No backward-compatibility impact.