Skip to content

Fix printDecimal regression for decimal values wider than a long #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 1 commit into from
Aug 26, 2026
Merged

Fix printDecimal regression for decimal values wider than a long #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/apache/xmlbeans/impl/util/XsTypeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ public static String printDecimal(BigDecimal value) {
// The following code comes from Apache Harmony
String intStr = value.unscaledValue().toString();
int scale = value.scale();
if (scale == 0 || (MathUtil.toLong(value) == 0 && scale < 0)) {
// the second branch only needs a zero check, as in the original Harmony code
if (scale == 0 || (value.signum() == 0 && scale < 0)) {
return intStr;
}

Expand Down
25 changes: 25 additions & 0 deletions src/test/java/misc/checkin/XsTypeConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import org.apache.xmlbeans.impl.values.XmlValueOutOfRangeException;
import org.junit.jupiter.api.Test;

import java.math.BigDecimal;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

Expand Down Expand Up @@ -309,4 +311,27 @@ public java.util.Iterator<String> getPrefixes(String uri) {
assertEquals("", empty.getLocalPart());
assertEquals(1, errors.size());
}

@Test
void printDecimalHandlesValuesWiderThanLong() {
assertEquals("123456789012345678901234567890.5",
XsTypeConverter.printDecimal(new BigDecimal("123456789012345678901234567890.5")));
assertEquals("-123456789012345678901234567890.5",
XsTypeConverter.printDecimal(new BigDecimal("-123456789012345678901234567890.5")));
}

@Test
void printDecimalHandlesNegativeScaleWiderThanLong() {
// stripTrailingZeros() and BigDecimal.valueOf(unscaled, negativeScale) both
// produce negative-scale values, which reach printDecimal via setBigDecimalValue.
assertEquals("100000000000000000000", XsTypeConverter.printDecimal(new BigDecimal("1E+20")));
assertEquals("-100000000000000000000", XsTypeConverter.printDecimal(new BigDecimal("-1E+20")));
assertEquals("100", XsTypeConverter.printDecimal(new BigDecimal("1E+2")));
}

@Test
void printDecimalHandlesZeroWithScale() {
assertEquals("0", XsTypeConverter.printDecimal(new BigDecimal("0E+5")));
assertEquals("0.00000", XsTypeConverter.printDecimal(new BigDecimal("0E-5")));
}
}