Skip to content

[ISSUE #2453] fix(consumers): canonicalize delivery order type - #2458

Open
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0820-yuluo-yx/fix-7
Open

[ISSUE #2453] fix(consumers): canonicalize delivery order type#2458
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0820-yuluo-yx/fix-7

Conversation

@yuluo-yx

Copy link
Copy Markdown
Member

Summary

  • submit MESSAGES_ORDER from the consumer creation form
  • accept the documented CSV value
  • canonicalize the legacy spaced CSV value before import

Verification

  • ConsumerPage and resourceCsvImport: 27 tests passed
  • targeted ESLint and Prettier checks passed
  • scope check: 80 changed lines

Fixes #2453

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Good catch on the space-vs-underscore inconsistency in MESSAGES_ORDER. The backward-compatible normalizeDeliveryOrderType in CSV import ensures existing imports with the old space-separated value still work. Test coverage for both forms is solid.

LGTM.


Automated review by github-manager

@RockteMQ-AI

Copy link
Copy Markdown

⚠️ Merge conflict detected

This PR has conflicts with the rocketmq-studio branch and cannot be merged. Please rebase or merge rocketmq-studio into your branch and resolve the conflicts:

git fetch origin
git checkout 0820-yuluo-yx/fix-7
git rebase origin/rocketmq-studio
# resolve conflicts, then:
git push --force-with-lease

This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.


Automated notification by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants