Skip to content

[ISSUE #2463] fix(auth): make status updates idempotent #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuluo-yx wants to merge 1 commit into
base: rocketmq-studio
Choose a base branch
from
Open

[ISSUE #2463] fix(auth): make status updates idempotent #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/src/main/java/org/apache/rocketmq/studio/auth/AuthService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ public RmqStudioUser createUser(String username, String password, boolean admin)
public RmqStudioUser setUserEnabled(Long userId, boolean enabled) {
requireDatabaseBacked();
RmqStudioUser user = getUser(userId);
if (Boolean.valueOf(enabled).equals(user.getEnabled())) {
return user;
}
if (!enabled && Boolean.TRUE.equals(user.getAdmin()) && enabledAdminCount() <= 1) {
throw new BusinessException(409, "The last enabled administrator cannot be disabled");
}
Expand Down
13 changes: 13 additions & 0 deletions server/src/test/java/org/apache/rocketmq/studio/auth/AuthServiceDatabaseTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,19 @@ void disablingLastEnabledAdministratorIsRejected() {
.hasMessage("The last enabled administrator cannot be disabled");
}

@Test
void disablingAnAlreadyDisabledAdministratorIsIdempotent() {
RmqStudioUser user = user(1L, "retired-admin", true, false, "password-1");
when(userMapper.selectById(1L)).thenReturn(user);

RmqStudioUser result = authService.setUserEnabled(1L, false);

assertThat(result).isSameAs(user);
verify(userMapper, never()).selectCount(any(Wrapper.class));
verify(userMapper, never()).updateById(any(RmqStudioUser.class));
verify(sessionMapper, never()).update(isNull(), any(Wrapper.class));
}

@Test
void databaseAuthenticationThrottlesLastSeenWrites() {
RmqStudioUser user = user(1L, "operator", false, true, "password-1");
Expand Down
Loading