Skip to content

[ISSUE #2464] fix(aliyun): normalize catalog inputs - #2468

Open
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0820-yuluo-yx/fix-14
Open

[ISSUE #2464] fix(aliyun): normalize catalog inputs#2468
yuluo-yx wants to merge 1 commit into
apache:rocketmq-studiofrom
yuluo-yx:0820-yuluo-yx/fix-14

Conversation

@yuluo-yx

@yuluo-yx yuluo-yx commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • strip region identifiers before Aliyun catalog client calls
  • normalize optional search text before local filtering
  • use stripped cloud instance identifiers in requests and errors

Verification

  • AliyunCatalogServiceTest: 10 tests passed
  • Checkstyle passed with 0 violations
  • scope check: 38 changed lines

Fixes #2464

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Normalizes Aliyun catalog inputs (regionId, search, cloudInstanceId) by stripping whitespace before use, preventing lookup failures from accidental spaces.

Strengths:

  • Consistent normalization across all Aliyun service methods
  • Proper null handling for optional search parameter
  • Test coverage for whitespace-padded inputs
  • Error messages use normalized values for clarity

LGTM — improves user experience with forgiving input handling.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants