[ISSUE #2465] fix(nameserver): deduplicate DNS address case - #2469
Open
yuluo-yx wants to merge 1 commit into
Open
[ISSUE #2465] fix(nameserver): deduplicate DNS address case#2469yuluo-yx wants to merge 1 commit into
yuluo-yx wants to merge 1 commit into
Conversation
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
RockteMQ-AI
approved these changes
Aug 20, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Deduplicates NameServer addresses case-insensitively for DNS hostnames, preventing duplicate connections when the same host is specified with different cases (e.g., ns.example.com vs NS.EXAMPLE.COM).
Strengths:
- Correct handling of IPv4 vs DNS (only lowercases DNS hostnames)
- Preserves original address format in output
- Skips IPv6 addresses (contains multiple colons) and zone IDs (contains
%) - Test verifies the deduplication behavior
LGTM — important fix for DNS-based deployments.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes #2465