TEZ-4747: Upgrade mockito to 5.23.0 - #529
Open
Aggarwal-Raghav wants to merge 1 commit into
Open
Conversation
Aggarwal-Raghav
commented
Jul 31, 2026
| verify(client2.sessionAmProxy, times(1)).shutdownSession(any(), | ||
| any()); | ||
| verify(client2.mockYarnClient, times(1)).stop(); | ||
| verify(client2.mockYarnClient, times(1)).close(); |
Contributor
Author
There was a problem hiding this comment.
Mockito4 couldn't mock final methods and yarnClient.close() was final so it was checking for stop() in AbstractService.java
@Override
public final void close() throws IOException {
stop();
}
But in Mockito 5 it can mock final method so it will test for close()
Aggarwal-Raghav
commented
Jul 31, 2026
| } | ||
| verify(activeLogger, times(0)).info(anyString()); | ||
| verify(aggregateLogger, times(1)).info(anyString(), ArgumentMatchers.<Object[]>any()); | ||
| verify(aggregateLogger, times(1)).info(anyString(), any(), any(), any(), any(), any()); |
|
💔 -1 overall
This message was automatically generated. |
Aggarwal-Raghav
force-pushed
the
TEZ-4747
branch
from
July 31, 2026 18:02
2bcb5e1 to
1fe287f
Compare
Aggarwal-Raghav
force-pushed
the
TEZ-4747
branch
from
July 31, 2026 21:02
1fe287f to
66132e0
Compare
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.