Skip to content

release(aisix-cp): 0.5.1#323

Merged
nic-6443 merged 1 commit into
mainfrom
release-aisix-cp-0.5.1
Jul 24, 2026
Merged

release(aisix-cp): 0.5.1#323
nic-6443 merged 1 commit into
mainfrom
release-aisix-cp-0.5.1

Conversation

@jarvis9443

Copy link
Copy Markdown
Contributor

Chart-only patch on top of the 0.5.0 app release. appVersion stays 0.5.0 — no application change, so every image still resolves to docker.io/...:0.5.0.

Problem

The chart kills both CP pods while they are still legitimately starting up.

dp-manager binds neither of its ports until it has obtained the shared schema, which cp-api creates. On a first boot it retries in-process for ~95s waiting for that — a race it is built to absorb. The liveness probe (initialDelaySeconds: 10, periodSeconds: 10, failureThreshold: 3) killed it about 40s in, well inside that window, so the pod never reached the end of its own retry budget.

cp-api has the same shape: it runs its schema migration before binding :8080, so /healthz stays unanswered for the whole migration. An empty database migrates fast, but an upgrade against a populated one can outlast the liveness budget and be killed mid-migration.

Change

A startupProbe on both deployments. While a startup probe is in effect the kubelet suspends liveness and readiness, so the existing probes are unchanged and take over once the process is actually serving. Budgets are sized to outlast the work they cover — 180s for dp-manager, 300s for cp-api's migration.

Verification

Both charts installed on kind with api.replicaCount=0, so dp-manager can never obtain its schema:

chart result
aisix-cp 0.5.0 (published) CrashLoopBackOff, 6 restarts, with the event Container dpm failed liveness probe, will be restarted
this branch (0.5.1) running, 0 restarts, no liveness-probe failures

helm lint passes, and the rendered manifests still resolve every image to docker.io/...:0.5.0.

Synced from the source-of-truth chart in AISIX-Cloud#1135; the residual diff against it is only the usual public adaptations (registries, empty tags resolving to .Chart.AppVersion, the api.dpImage default, and README.md).

Chart-only patch on top of the 0.5.0 app release: add a startupProbe to
cp-api and dp-manager so the liveness probe stops killing them while they
are still legitimately bootstrapping. appVersion stays 0.5.0 — no
application change.

dp-manager binds neither of its ports until it has obtained the shared
schema, which cp-api creates; on a first boot it retries in-process for
~95s waiting for that. The liveness probe killed it about 40s in, well
inside that window, so a benign boot race became a crash loop. cp-api has
the same shape: it runs its migration before binding :8080, so /healthz
stays unanswered for the whole migration and an upgrade against a
populated database can be killed mid-migration.

While a startup probe is in effect the kubelet suspends liveness and
readiness, so the existing probes are unchanged and take over once the
process is serving. Budgets outlast the work they cover: 180s for
dp-manager, 300s for cp-api's migration.

Synced from the source-of-truth chart in AISIX-Cloud#1135.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5447a2b-f832-4230-8caa-c7511865101a

📥 Commits

Reviewing files that changed from the base of the PR and between 3774feb and 67c0ac3.

📒 Files selected for processing (4)
  • charts/aisix-cp/Chart.yaml
  • charts/aisix-cp/README.md
  • charts/aisix-cp/templates/api-deployment.yaml
  • charts/aisix-cp/templates/dpm-deployment.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release-aisix-cp-0.5.1

Comment @coderabbitai help to get the list of available commands.

@nic-6443
nic-6443 merged commit 82b0af4 into main Jul 24, 2026
3 checks passed
@nic-6443
nic-6443 deleted the release-aisix-cp-0.5.1 branch July 24, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants