release(aisix-cp): 0.5.1#323
Conversation
Chart-only patch on top of the 0.5.0 app release: add a startupProbe to cp-api and dp-manager so the liveness probe stops killing them while they are still legitimately bootstrapping. appVersion stays 0.5.0 — no application change. dp-manager binds neither of its ports until it has obtained the shared schema, which cp-api creates; on a first boot it retries in-process for ~95s waiting for that. The liveness probe killed it about 40s in, well inside that window, so a benign boot race became a crash loop. cp-api has the same shape: it runs its migration before binding :8080, so /healthz stays unanswered for the whole migration and an upgrade against a populated database can be killed mid-migration. While a startup probe is in effect the kubelet suspends liveness and readiness, so the existing probes are unchanged and take over once the process is serving. Budgets outlast the work they cover: 180s for dp-manager, 300s for cp-api's migration. Synced from the source-of-truth chart in AISIX-Cloud#1135.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Chart-only patch on top of the 0.5.0 app release.
appVersionstays0.5.0— no application change, so every image still resolves todocker.io/...:0.5.0.Problem
The chart kills both CP pods while they are still legitimately starting up.
dp-manager binds neither of its ports until it has obtained the shared schema, which cp-api creates. On a first boot it retries in-process for ~95s waiting for that — a race it is built to absorb. The liveness probe (
initialDelaySeconds: 10,periodSeconds: 10,failureThreshold: 3) killed it about 40s in, well inside that window, so the pod never reached the end of its own retry budget.cp-api has the same shape: it runs its schema migration before binding
:8080, so/healthzstays unanswered for the whole migration. An empty database migrates fast, but an upgrade against a populated one can outlast the liveness budget and be killed mid-migration.Change
A
startupProbeon both deployments. While a startup probe is in effect the kubelet suspends liveness and readiness, so the existing probes are unchanged and take over once the process is actually serving. Budgets are sized to outlast the work they cover — 180s for dp-manager, 300s for cp-api's migration.Verification
Both charts installed on kind with
api.replicaCount=0, so dp-manager can never obtain its schema:aisix-cp0.5.0 (published)CrashLoopBackOff, 6 restarts, with the eventContainer dpm failed liveness probe, will be restartedhelm lintpasses, and the rendered manifests still resolve every image todocker.io/...:0.5.0.Synced from the source-of-truth chart in AISIX-Cloud#1135; the residual diff against it is only the usual public adaptations (registries, empty tags resolving to
.Chart.AppVersion, theapi.dpImagedefault, andREADME.md).