Moves all transaction logic to a PORO's business class - #83
Open
thiagocifani wants to merge 3 commits into
Open
Conversation
amazon payment gateway was moved to transaction.rb and payment option conditionals to payment_options_checker.
thiagocifani
referenced
this pull request
in paterson/selfstarter
Mar 20, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've moved some logic that was on preorder controller to a specific service class. I didn't add any test yet, but if need to pull request this changes, I will be happy to help somehow. I never used this repo before, but I've worked in a project that was inspired in your work. I feel happy to help somehow. Feel free to ask anything or change.