Skip to content

REFACTOR: consolidate duplicate SVG icon components into centralized pattern #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Talha12Shiekh wants to merge 1 commit into
base: next
Choose a base branch
from
Open

REFACTOR: consolidate duplicate SVG icon components into centralized pattern #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions packages/web/src/components/shared/AutofillSvg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,3 @@
import React from 'react';
import styled from '@emotion/styled';

const AutofillSvgIcon = styled.button`
display: flex;
margin-left: auto;
position: relative;
right: -3px;
border: none;
outline: none;
background: transparent;
padding: 0;
z-index: 111;

svg {
cursor: pointer;
fill: #707070;
height: 17px;
}

&:hover {
svg {
fill: #1c1a1a;
}
}
`;

const SelectArrowSvg = props => (
<AutofillSvgIcon {...props}>
<svg viewBox="0 0 24 24">
<path d="M8 17v-7.586l8.293 8.293c0.391 0.391 1.024 0.391 1.414 0s0.391-1.024 0-1.414l-8.293-8.293h7.586c0.552 0 1-0.448 1-1s-0.448-1-1-1h-10c-0.552 0-1 0.448-1 1v10c0 0.552 0.448 1 1 1s1-0.448 1-1z" />
</svg>
</AutofillSvgIcon>
);
import { SelectArrowSvg } from './Icons';

export default SelectArrowSvg;
23 changes: 1 addition & 22 deletions packages/web/src/components/shared/CancelSvg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,3 @@
import React from 'react';
import types from '@appbaseio/reactivecore/lib/utils/types';

const CancelSvg = ({ onClick }) => (
<svg
onClick={onClick}
alt="Clear"
className="cancel-icon"
xmlns="http://www.w3.org/2000/svg"
height="20px"
viewBox="0 0 24 24"
width="20px"
>
<title>Clear</title>
<path d="M0 0h24v24H0V0z" fill="none" />
<path d="M19 6.41L17.59 5 12 10.59 6.41 5 5 6.41 10.59 12 5 17.59 6.41 19 12 13.41 17.59 19 19 17.59 13.41 12 19 6.41z" />
</svg>
);

CancelSvg.propTypes = {
onClick: types.func,
};
import { CancelSvg } from './Icons';

export default CancelSvg;
13 changes: 1 addition & 12 deletions packages/web/src/components/shared/DownloadSvg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,3 @@
import React from 'react';
import styled from '@emotion/styled';

const DownloadSvgWrapper = styled.span`
text-decoration: underline;
text-decoration-thickness: 2px;
position: relative;
top: -1px;
margin-left: 2px;
`;

const DownloadSvg = props => <DownloadSvgWrapper {...props}>⬇</DownloadSvgWrapper>;
import { DownloadSvg } from './Icons';

export default DownloadSvg;
Loading