Skip to content

FIX(security): validate URL search parameter schema before Redux store injection (#2319) #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Talha12Shiekh wants to merge 1 commit into
base: next
Choose a base branch
from
Open

FIX(security): validate URL search parameter schema before Redux store injection (#2319) #2333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions packages/web/src/components/basic/ReactiveBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,55 @@ class ReactiveBase extends Component {
let selectedValues = {};
let urlValues = {};

const isValidURLValue = (value) => {
if (value === null || value === undefined) return false;
const type = typeof value;
if (type === 'string' || type === 'number' || type === 'boolean') return true;
if (Array.isArray(value)) {
return value.every((item) => {
const itemType = typeof item;
return itemType === 'string' || itemType === 'number' || itemType === 'boolean';
});
}
if (type === 'object' && value.constructor === Object) {
return Object.values(value).every((item) => {
const itemType = typeof item;
return itemType === 'string' || itemType === 'number' || itemType === 'boolean' || item === null;
});
}
return false;
};

const isValidParsedParam = (parsedParams) => {
if (parsedParams === null || parsedParams === undefined) return false;
const type = typeof parsedParams;
if (type === 'string' || type === 'number' || type === 'boolean' || Array.isArray(parsedParams)) {
return true;
}
if (type === 'object' && parsedParams.constructor === Object) {
if (Object.prototype.hasOwnProperty.call(parsedParams, 'value')) {
return isValidURLValue(parsedParams.value);
}
return isValidURLValue(parsedParams);
}
return false;
};

Array.from(params.keys()).forEach((key) => {
try {
const parsedParams = JSON.parse(params.get(key));
if (!isValidParsedParam(parsedParams)) {
return;
}
const selectedValue = {};
if (parsedParams.value) {
if (parsedParams && typeof parsedParams === 'object' && Object.prototype.hasOwnProperty.call(parsedParams, 'value')) {
selectedValue.value = parsedParams.value;
} else {
selectedValue.value = parsedParams;
}
if (parsedParams.category) selectedValue.category = parsedParams.category;
if (parsedParams && parsedParams.category && typeof parsedParams.category === 'string') {
selectedValue.category = parsedParams.category;
}
selectedValue.reference = 'URL';
selectedValues = {
...selectedValues,
Expand Down