FEAT(web): add showItemCount and renderTitle props to MultiList and SingleList (#1603) - #2334
Open
Talha12Shiekh wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Resolves issue #1603 by adding
showItemCountandrenderTitleprops toMultiListandSingleListcomponents:showItemCount(Boolean prop, default:false): When enabled, renders the count of active/filtered list items next to the title header inMultiListandSingleList.renderTitle(Function / Node prop): Provides a custom renderer functionrenderTitle(itemsCount, listItems)allowing developers to fully customize title rendering and display item counts.MultiList.d.ts,SingleList.d.ts,propTypes, anddefaultProps.Linked Issues
[Feature Request] item count next to Title in MultiList)Usage Example:
Checklist
Improvements to the Library Experience
Side Effects
showItemCountdefaults tofalse).Testing
MultiList.js,SingleList.js,MultiList.d.ts, andSingleList.d.ts.