Skip to content

fix(ADFA-4892): Refresh search on re-opening search bar - #1640

Merged
dara-abijo-adfa merged 2 commits into
stagefrom
bug/ADFA-4892-log-search-not-working-after-filter
Aug 11, 2026
Merged

fix(ADFA-4892): Refresh search on re-opening search bar#1640
dara-abijo-adfa merged 2 commits into
stagefrom
bug/ADFA-4892-log-search-not-working-after-filter

Conversation

@dara-abijo-adfa

Copy link
Copy Markdown
Contributor

Fix log search persistence on filter toggle and re-opening.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eee8acc7-b4a5-4da4-9b9a-987e59d4556c

📥 Commits

Reviewing files that changed from the base of the PR and between 62d5573 and d3c83fe.

📒 Files selected for processing (1)
  • editor/src/main/java/com/itsaky/androidide/editor/ui/EditorSearchLayout.kt

📝 Walkthrough
  • Refreshes the current log search when the search bar reopens.
  • Initializes the current search before navigation or replacement actions.
  • Fixes search persistence when users toggle filters.

Walkthrough

The editor search layout now refreshes the current search when search mode starts and before handling actions when no query exists.

Changes

Search state refresh

Layer / File(s) Summary
Refresh search entry points
editor/src/main/java/com/itsaky/androidide/editor/ui/EditorSearchLayout.kt
beginSearchMode refreshes search state before focusing the input. onSearchActionClick refreshes search state before its existing no-query handling.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: daniel-adfa, itsaky-adfa, jatezzz

Poem

A bunny checks the searcher's state,
Before the keys can navigate.
Fresh results hop into the view,
Actions know just what to do.
Search begins with carrots bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix: refreshing search when the search bar is reopened.
Description check ✅ Passed The description accurately relates to search persistence during filter toggling and search bar reopening.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug/ADFA-4892-log-search-not-working-after-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dara-abijo-adfa
dara-abijo-adfa merged commit a1700fa into stage Aug 11, 2026
4 checks passed
@dara-abijo-adfa
dara-abijo-adfa deleted the bug/ADFA-4892-log-search-not-working-after-filter branch August 11, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants