ADFA-5107: Add Claude-facing reference for the documentation database - #1661
Conversation
Combines the Confluence design doc and docdb-studio's CLAUDE.md/SCHEMA.md into docs/documentation-database.md, cross-checked against WebServer.kt, ToolTipManager.kt, and PluginDocumentationManager.kt so it reflects actual behavior. Linked from ARCHITECTURE.md and ADR 0001 for discoverability.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 Walkthrough
WalkthroughThe change documents the read-only ChangesDocumentation database guidance
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR adds and cross-links documentation without changing product behavior or runtime code, so no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ARCHITECTURE.md`:
- Around line 106-107: Update the documentation database reference sentence in
ARCHITECTURE.md to include the in-app/plugin-help consumer alongside tooltips
and local-web-server exceptions. Preserve the existing documentation.db
description and link, and ensure PluginDocumentationManager.kt is represented as
a consumer.
In `@docs/documentation-database.md`:
- Line 3: Update the opening description in the documentation database reference
to state that tooltips provide Tier 1/2 content, while Tier 3 content is served
by WebServer and linked from the tooltips. Keep the existing database ownership
and scope guidance unchanged.
- Line 38: Update the uniqueness description in the documentation near the
existing UNIQUE(path) schema declaration to state that duplicate paths are
currently rejected even when languageID differs. Clarify that composite
uniqueness on path and languageID is the future upstream schema change, and
align the later uniqueness statement so both sections describe the current
constraint consistently.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c86ec2de-239f-48f4-9f9e-ca7aa3e9e259
📒 Files selected for processing (3)
ARCHITECTURE.mddocs/adr/0001-prefer-room-for-persistence.mddocs/documentation-database.md
- List all three raw-SQLite exceptions (tooltips, in-app/plugin-help, local web server) as documentation.db consumers in ARCHITECTURE.md, not just two. - Stop calling Tier 3 content "tooltips" -- tooltips are Tier 1/2; Tier 3 is the web content they link to. - Fix a self-contradiction: Content.UNIQUE(path) rejects any duplicate path regardless of languageID, it does not permit same-path rows that differ only by language. One passage said otherwise.
Summary
docs/documentation-database.md, combining the Confluence design doc fordocumentation.db(Tier 1/2/3 help) withdocdb-studio'sCLAUDE.md/SCHEMA.md, cross-checked againstWebServer.kt,ToolTipManager.kt, andPluginDocumentationManager.ktso it reflects actual consumer behavior.ARCHITECTURE.md's persistence-policy callout and from ADR 0001's raw-SQLite exceptions table, so it's discoverable from paths already read for architecture/persistence questions.Test plan
spotlessCheckpassed via the pre-push hook.🤖 Generated with Claude Code